Re: [PATCH 5/5] arm64: dts: qcom: Shikra LT9611UXD support

[Krzysztof Kozlowski]

On 27/06/2026 12:01, Nabige Aala wrote:
> From: Mohit Dsor <mohit.dsor@xxxxxxxxxxxxxxxx>
> 
> Device tree changes to support lt9611uxd hdmi-dsi driver.
> 
> Signed-off-by: Mohit Dsor <mohit.dsor@xxxxxxxxxxxxxxxx>

Incomplete DCO

...

> +
>  	vreg_wcn_3p3: regulator-wcn-3p3 {
>  		compatible = "regulator-fixed";
>  		regulator-name = "wcn_3p3";
> @@ -68,6 +98,78 @@ vreg_pmu_ch1: ldo4 {
>  	};
>  };
>  
> +&i2c4 {
> +	status = "okay";
> +
> +	lt9611uxd: lt9611uxd@41 {

No. Nice try. Instead of fixing broken driver (I reported this), you
send broken workaround which is in clear violations of coding style and
DT spec.

That's a poor way to upstream things. Just throwing the code over the wall.


Best regards,
Krzysztof