Re: [PATCH] usb: free iso schedules on failed submit

From: Dawei Feng

Date: Sun Jun 28 2026 - 07:23:52 EST


Hi, Alan,

Thanks for the review.

On Sat, 27 Jun 2026 15:05:57 -0400, Alan Stern wrote:
>> }
>> done_not_linked:
>> + if (status < 0) {
>> + iso_sched_free(stream, urb->hcpriv);
>> + urb->hcpriv = NULL;
>> + }
>
>That's not quite optimal, because iso_stream_schedule() already calls
>iso_sched_free() whenever its return value is < 0. You should remove
>that call now that the deallocation is being done down here. And also
>have iso_stream_schedule() clear urb->hcpriv in the other place where it
>calls iso_sched_free().

You are right. I'll update it in v2.

Best regards,
Dawei