Re: [PATCH v4 4/5] mm/vmscan: extract folio unmap logic into folio_try_unmap()

From: Zhang Peng

Date: Sun Jun 28 2026 - 12:11:20 EST


On Wed, Jun 17, 2026 at 02:28:42PM +0200, David Hildenbrand wrote:
> Two tabs.
> folio_try_unmap() vs. try_to_unmap() Hm.
> const bool was_swapbacked = folio_test_swapbacked(folio);
> Probably best in a single line.

Fixed alignment, const, and joined the short conditions.

On the name: I'll keep it as folio_try_unmap() — it's static in
vmscan.c, no risk of collision with try_to_unmap(), and the try_
already tells you what it does.  If the _for_reclaim suffix matters
to you I'll add it, just let me know.