Re: [PATCH v2] net: usb: rtl8150: handle link status read failures

From: Andrew Lunn

Date: Sun Jun 28 2026 - 12:41:45 EST


On Sun, Jun 28, 2026 at 06:25:28PM +0200, Yousef Alhouseen wrote:
> set_carrier() ignores the result of the USB control transfer and tests
> the stack variable supplied as its receive buffer. If the device rejects
> or aborts the request, that variable remains uninitialized and the driver
> chooses an arbitrary carrier state.
>
> Leave the existing carrier state unchanged when the link status cannot be
> read. A transient USB error should not be treated as link loss.
>
> Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
> Reported-by: syzbot+9db6c624635564ad813c@xxxxxxxxxxxxxxxxxxxxxxxxx
> Closes: https://syzkaller.appspot.com/bug?extid=9db6c624635564ad813c
> Cc: stable@xxxxxxxxxxxxxxx

https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html

Does this issue bother people?

I think it would be better to submit to net-next:

https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html

Please don't thread patch versions together.

Also, a Suggested-by: might be appropriate here.

Andrew

---
pw-bot: cr