Re: [PATCH iproute2-next] devlink: support u32-array values in devlink param show/set

[David Ahern]

On 6/14/26 10:10 PM, Ratheesh Kannoth wrote:
> @@ -3904,6 +3935,14 @@ static int cmd_dev_param_set(struct dl *dl)
>  		if (!strcmp(dl->opts.param_value, ctx.value.vstr))
>  			return 0;
>  		break;
> +	case 129:

no magic numbers. What does 129 represent? Is there a named macro for
it? If not, why not if this is part of a UAPI?

> +		buf = (char *)dl->opts.param_value;
> +		token = strtok(buf,  delim);
> +		while (token) {
> +			mnl_attr_put_u32(nlh, DEVLINK_ATTR_PARAM_VALUE_DATA, atoi(token));
> +			token = strtok(NULL, delim);
> +		}
> +		break;
>  	default:
>  		printf("Value type not supported\n");
>  		return -ENOTSUP;