Re: [PATCH v6 01/17] dt-bindings: pinctrl: airoha: update/fix device tree binding schemas

[Conor Dooley]

On Sun, Jun 28, 2026 at 05:37:17PM +0300, Mikhail Kshevetskiy wrote:
> This patch fix several misprints and sync device tree binding schemas
> with actual driver code.

Please split this up and provide some explanation for why each thing is
incorrect.

pw-bot: changes-requested

> 

Missing a Fixes: tag.

Thanks,
Conor.

> Signed-off-by: Mikhail Kshevetskiy <mikhail.kshevetskiy@xxxxxxxxx>
> ---
>  .../pinctrl/airoha,an7583-pinctrl.yaml        | 37 +++++++------------
>  .../pinctrl/airoha,en7581-pinctrl.yaml        |  4 +-
>  2 files changed, 16 insertions(+), 25 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
> index 79910214d9b5..f52802a3ad79 100644
> --- a/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/airoha,an7583-pinctrl.yaml
> @@ -61,7 +61,7 @@ patternProperties:
>              description:
>                A string containing the name of the function to mux to the group.
>              enum: [pon, tod_1pps, sipo, mdio, uart, i2c, jtag, pcm, spi,
> -                   pcm_spi, i2s, emmc, pnand, pcie_reset, pwm, phy1_led0,
> +                   pcm_spi, emmc, pnand, pcie_reset, pwm, phy1_led0,
>                     phy2_led0, phy3_led0, phy4_led0, phy1_led1, phy2_led1,
>                     phy3_led1, phy4_led1]
>  
> @@ -159,17 +159,8 @@ patternProperties:
>                properties:
>                  groups:
>                    items:
> -                    enum: [pcm_spi, pcm_spi_int, pcm_spi_rst, pcm_spi_cs1,
> -                           pcm_spi_cs2, pcm_spi_cs3, pcm_spi_cs4]
> -                  maxItems: 7
> -          - if:
> -              properties:
> -                function:
> -                  const: i2c
> -            then:
> -              properties:
> -                groups:
> -                  enum: [i2s]
> +                    enum: [pcm_spi, pcm_spi_rst, pcm_spi_cs1]
> +                  maxItems: 3
>            - if:
>                properties:
>                  function:
> @@ -207,7 +198,8 @@ patternProperties:
>                           gpio20, gpio21, gpio22, gpio23, gpio24, gpio25,
>                           gpio26, gpio27, gpio28, gpio29, gpio30, gpio31,
>                           gpio36, gpio37, gpio38, gpio39, gpio40, gpio41,
> -                         gpio42, gpio43, gpio44, gpio45, gpio46, gpio47]
> +                         gpio42, gpio43, gpio44, gpio45, gpio46, gpio47,
> +                         gpio48]
>            - if:
>                properties:
>                  function:
> @@ -288,17 +280,16 @@ patternProperties:
>              description:
>                An array of strings. Each string contains the name of a pin.
>              items:
> -              enum: [uart1_txd, uart1_rxd, i2c_scl, i2c_sda, spi_cs0, spi_clk,
> -                     spi_mosi, spi_miso, gpio0, gpio1, gpio2, gpio3, gpio4,
> -                     gpio5, gpio6, gpio7, gpio8, gpio9, gpio10, gpio11, gpio12,
> -                     gpio13, gpio14, gpio15, gpio16, gpio17, gpio18, gpio19,
> -                     gpio20, gpio21, gpio22, gpio23, gpio24, gpio25, gpio26,
> -                     gpio27, gpio28, gpio29, gpio30, gpio31, gpio32, gpio33,
> -                     gpio34, gpio35, gpio36, gpio37, gpio38, gpio39, gpio40,
> -                     gpio41, gpio42, gpio43, gpio44, gpio45, gpio46,
> -                     pcie_reset0, pcie_reset1, pcie_reset2]
> +              enum: [gpio0, gpio1, gpio2, gpio3, gpio4, gpio5, gpio6, gpio7,
> +                     gpio8, gpio9, gpio10, gpio11, gpio12, gpio13, gpio14,
> +                     gpio15, gpio16, gpio17, gpio18, gpio19, gpio20, gpio21,
> +                     gpio22, gpio23, gpio24, gpio25, gpio26, gpio27, gpio28,
> +                     gpio29, gpio30, gpio31, gpio32, gpio33, gpio34, gpio35,
> +                     gpio36, gpio37, gpio38, i2c0_scl, i2c0_sda, i2c1_scl,
> +                     i2c1_sda, spi_clk, spi_cs, spi_mosi, spi_miso, uart_txd,
> +                     uart_rxd, pcie_reset0, pcie_reset1, mdc_0, mdio_0]
>              minItems: 1
> -            maxItems: 58
> +            maxItems: 53
>  
>            bias-disable: true
>  
> diff --git a/Documentation/devicetree/bindings/pinctrl/airoha,en7581-pinctrl.yaml b/Documentation/devicetree/bindings/pinctrl/airoha,en7581-pinctrl.yaml
> index 21fd4f1ba78b..12dd85b5b410 100644
> --- a/Documentation/devicetree/bindings/pinctrl/airoha,en7581-pinctrl.yaml
> +++ b/Documentation/devicetree/bindings/pinctrl/airoha,en7581-pinctrl.yaml
> @@ -166,7 +166,7 @@ patternProperties:
>            - if:
>                properties:
>                  function:
> -                  const: i2c
> +                  const: i2s
>              then:
>                properties:
>                  groups:
> @@ -208,7 +208,7 @@ patternProperties:
>                           gpio20, gpio21, gpio22, gpio23, gpio24, gpio25,
>                           gpio26, gpio27, gpio28, gpio29, gpio30, gpio31,
>                           gpio36, gpio37, gpio38, gpio39, gpio40, gpio41,
> -                         gpio42, gpio43, gpio44, gpio45, gpio46, gpio47]
> +                         gpio42, gpio43, gpio44, gpio45, gpio46]
>            - if:
>                properties:
>                  function:
> -- 
> 2.53.0
>

Attachment: signature.asc
Description: PGP signature