Re: [PATCH 2/3] minix: convert address space operations to iomap

[Jeremy Bingham]

Greetings, Xiao.

On Sun, Jun 28, 2026 at 11:48 AM XIAO WU <xiaowu.417@xxxxxx> wrote:
>
> Hi Jeremy,
>
> I came across the Sashiko AI review of this patch series and reproduced
> one of the issues it flagged -- a NULL pointer dereference when creating
> a symlink on a mounted minix filesystem. The crash is deterministic and
> triggers on the first symlink() call.
>
> The Sashiko review page is at:
> https://sashiko.dev/#/patchset/cover.1782422707.git.jbingham@xxxxxxxxx

Thank you for bringing the Sashiko AI review to my attention. I had already
seen the syzbot failure report and was aware of the failure, but I appreciate
learning about other automated testing things out there. I was able to duplicate
the bug locally with "ln -s" as well.

> I see you already have test patches via the syzbot test infrastructure
> that add write_begin/write_end back to minix_aops -- great!  This PoC
> can serve as a concrete reproducer to verify the fix.

Yes, and I recently sent out a v2 patch series that fixed the issues that szybot
found. Unfortunately syzbot found a couple more bugs that I need to
investigate, but at least they're new. I'm setting things up locally
to (hopefully)
ensure that there will not be a need for a v4 round of patches for this, unless
someone finds a broader issue that needs to be addressed.

> Thanks,
> Xiao

Thank you, good person.

-j