RE: [PATCH v1] ASoC: Intel: soc-acpi-ptl-match: add tas2783 support

[Liao, Bard]

> -----Original Message-----
> From: Baojun Xu <baojun.xu@xxxxxx>
> Sent: Sunday, June 28, 2026 8:26 PM
> To: broonie@xxxxxxxxxx
> Cc: tiwai@xxxxxxx; andriy.shevchenko@xxxxxxxxxxxxxxx;
> 13916275206@xxxxxxx; alsa-devel@xxxxxxxxxxxxxxxx; shenghao-
> ding@xxxxxx; baojun.xu@xxxxxx; linux-sound@xxxxxxxxxxxxxxx; linux-
> kernel@xxxxxxxxxxxxxxx; Yi, ChEN KAI <k-yi@xxxxxx>; Lo, Henry
> <henry.lo@xxxxxx>; robinchen@xxxxxx; Holalu Yogendra, Niranjan
> <niranjan.hy@xxxxxx>
> Subject: [PATCH v1] ASoC: Intel: soc-acpi-ptl-match: add tas2783 support
> 
> Added tas2783 support in some projects.
> 
> Signed-off-by: Baojun Xu <baojun.xu@xxxxxx>
> ---
>  sound/soc/amd/acp/amd-acp70-acpi-match.c      | 64 ++++++++++++++++

"Intel" is added to the title, but the commit changes the AMD file, too

>  .../intel/common/soc-acpi-intel-ptl-match.c   | 74 +++++++++++++++++++
>  2 files changed, 138 insertions(+)
> 
> diff --git a/sound/soc/intel/common/soc-acpi-intel-ptl-match.c
> b/sound/soc/intel/common/soc-acpi-intel-ptl-match.c
> index f7694b2a2b02..6b27b09d9f98 100644
> --- a/sound/soc/intel/common/soc-acpi-intel-ptl-match.c
> +++ b/sound/soc/intel/common/soc-acpi-intel-ptl-match.c
>  static const struct snd_soc_acpi_link_adr ptl_cs42l43_agg_l3_cs35l56_l2[] = {
>  	{
>  		.mask = BIT(3),
> @@ -464,6 +526,18 @@ struct snd_soc_acpi_mach
> snd_soc_acpi_intel_ptl_sdw_machines[] = {
>  		.drv_name = "sof_sdw",
>  		.sof_tplg_filename = "sof-ptl-rt722.tplg", /* Reuse the existing
> tplg file */
>  	},
> +	{
> +		.link_mask = BIT(1) | BIT(2),
> +		.links = tas2783_link0,
> +		.drv_name = "sof_sdw",
> +		.sof_tplg_filename = "sof-ptl-tas2783-2ch.tplg",
> +	},
> +	{
> +		.link_mask = BIT(2),
> +		.links = tas2783_link1,
> +		.drv_name = "sof_sdw",
> +		.sof_tplg_filename = "sof-ptl-tas2783-2ch.tplg",
> +	},

Is there any particular reason that you need to add the mach table for
the audio configurations? For Intel PTL+ platforms, the SOF driver will
generate the acpi mach table based on the reported acpi table and use
function topology. That means we don't need to create new acpi mach
table and topologies for new audio configurations.

>  	{
>  		.link_mask = BIT(1) | BIT(2) | BIT(3),
>  		.links = ptl_sdw_rt713_vb_l2_rt1320_l13,
> --
> 2.25.1
>