Re: [PATCH v5 4/7] drm/verisilicon: make axi and ahb clocks optional

[Joey Lu]

On 6/26/2026 4:03 PM, Icenowy Zheng wrote:
> 在 2026-06-25四的 17:44 +0800，Joey Lu写道：
> > The Nuvoton MA35D1 SoC integrates a DCUltraLite display controller
> > whose
> > AXI and AHB bus clocks share a single gate enable bit with the
> > display
> > core clock, so the clock driver does not expose them separately. This
> > patch makes the axi and ahb clocks optional in the probe.
> >
> > Signed-off-by: Joey Lu <a0987203069@xxxxxxxxx>
> ```
> Reviewed-by: Icenowy Zheng <zhengxingda@xxxxxxxxxxx>
> ```
>
> Thanks,
> Icenowy
Thank you for the review. I will revert this patch entirely. As discussed
in the binding review, axi and ahb clocks will now always be supplied in
the devicetree using the same phandle as the core clock gate, so making
them optional in the driver is no longer needed.
> > ---
> >   drivers/gpu/drm/verisilicon/vs_dc.c | 4 ++--
> >   1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/verisilicon/vs_dc.c
> > b/drivers/gpu/drm/verisilicon/vs_dc.c
> > index 9729b693d360..fd1f5fe67a68 100644
> > --- a/drivers/gpu/drm/verisilicon/vs_dc.c
> > +++ b/drivers/gpu/drm/verisilicon/vs_dc.c
> > @@ -90,13 +90,13 @@ static int vs_dc_probe(struct platform_device
> > *pdev)
> >   		return PTR_ERR(dc->core_clk);
> >   	}
> >   
> > -	dc->axi_clk = devm_clk_get_enabled(dev, "axi");
> > +	dc->axi_clk = devm_clk_get_optional_enabled(dev, "axi");
> >   	if (IS_ERR(dc->axi_clk)) {
> >   		dev_err(dev, "can't get axi clock\n");
> >   		return PTR_ERR(dc->axi_clk);
> >   	}
> >   
> > -	dc->ahb_clk = devm_clk_get_enabled(dev, "ahb");
> > +	dc->ahb_clk = devm_clk_get_optional_enabled(dev, "ahb");
> >   	if (IS_ERR(dc->ahb_clk)) {
> >   		dev_err(dev, "can't get ahb clock\n");
> >   		return PTR_ERR(dc->ahb_clk);