Re: [PATCH v7] rust: aref: make `AlwaysRefCounted::inc_ref` an associated function
From: Viresh Kumar
Date: Mon Jun 29 2026 - 00:39:49 EST
On 28-06-26, 18:07, Trevor Chan wrote:
> diff --git a/rust/kernel/opp.rs b/rust/kernel/opp.rs
> index 62e44676125d..84802f22b652 100644
> --- a/rust/kernel/opp.rs
> +++ b/rust/kernel/opp.rs
> @@ -1043,9 +1043,9 @@ unsafe impl Sync for OPP {}
> /// SAFETY: The type invariants guarantee that [`OPP`] is always refcounted.
> unsafe impl AlwaysRefCounted for OPP {
> #[inline]
> - fn inc_ref(&self) {
> + fn inc_ref(obj: &Self) {
> // SAFETY: The existence of a shared reference means that the refcount is nonzero.
> - unsafe { bindings::dev_pm_opp_get(self.0.get()) };
> + unsafe { bindings::dev_pm_opp_get(obj.0.get()) };
> }
>
> #[inline]
For OPP:
Acked-by: Viresh Kumar <viresh.kumar@xxxxxxxxxx>
--
viresh