Re: [PATCH v1 2/3] ASoC: qcom: lpass-rx-macro: Add shikra compatible

[Mohammad Rafi Shaik]

On 6/9/2026 12:58 PM, Krzysztof Kozlowski wrote:
> On Mon, Jun 08, 2026 at 10:50:22PM +0530, Mohammad Rafi Shaik wrote:
> > @@ -3648,6 +3655,7 @@ static int rx_macro_component_probe(struct snd_soc_component *component)
> >   	case LPASS_CODEC_VERSION_2_6:
> >   	case LPASS_CODEC_VERSION_2_7:
> >   	case LPASS_CODEC_VERSION_2_8:
> > +	case LPASS_CODEC_VERSION_4_0:
> >   		controls = rx_macro_2_5_snd_controls;
> >   		num_controls = ARRAY_SIZE(rx_macro_2_5_snd_controls);
> >   		widgets = rx_macro_2_5_dapm_widgets;
> > @@ -3809,6 +3817,7 @@ static int rx_macro_probe(struct platform_device *pdev)
> >   		return PTR_ERR(base);
> >   
> >   	rx->codec_version = lpass_macro_get_codec_version();
> > +	rx->bypass_fs_control = !!(flags & LPASS_MACRO_FLAG_BYPASS_FS_CONTROL);
>
> Is this specific to Shikra or LPASS v4 codec version? Commit msg
> suggests latter, so detectable from version, no?

Agree, this should not be Shikra-specific.

The behavior is tied to the LPASS codec version, so it’s better to 
configure it based on the detected version rather than flags.

I’ll update the implementation accordingly in the next revision.


Thanks & Regards,
Rafi.

> >   	struct reg_default *reg_defaults __free(kfree) = NULL;
> >   
> >   	switch (rx->codec_version) {
> > @@ -3831,6 +3840,7 @@ static int rx_macro_probe(struct platform_device *pdev)
> >   	case LPASS_CODEC_VERSION_2_6:
> >   	case LPASS_CODEC_VERSION_2_7:
> >   	case LPASS_CODEC_VERSION_2_8:
> > +	case LPASS_CODEC_VERSION_4_0:
>
> Best regards,
> Krzysztof