Re: [PATCH 2/2] spi: qcom-geni: Add property to force GSI mode

[Mukesh Savaliya]

On 6/27/2026 10:52 AM, Pengyu Luo wrote:
[...]
> > > > This hunk is very odd:
> > > >
> > > > /*
> > > >    * in case of failure to get gpi dma channel, we can still do the
> > > >    * FIFO mode, so fallthrough
> > > >    */
> > > > dev_warn(mas->dev, "FIFO mode disabled, but couldn't get DMA, fall back to FIFO mode\n");
> > > >
> > > > In my understanding, GSI DMA mode is always preferable. +Mukesh, do
> > > > you have any insights?
> > > GSI mode is preferable but if for some reason it fails, we try to continue with the FIFO mode. Just fallback mechanism.
> >
> > So, would making GSI the default and FIFO the fallback option
> > sound good?
>
> Yes, I have sent v2, please check here
> https://lore.kernel.org/linux-arm-msm/20260616122605.668908-1-mitltlatltl@xxxxxxxxx
Just Reviewed and Commented on V2.
> Best wishes,
> Pengyu
>
> > Konrad