Re: [PATCH v6 05/17] pinctrl: airoha: an7581: fix mux/conf of pcie_reset pins

[Krzysztof Kozlowski]

On Sun, Jun 28, 2026 at 05:37:21PM +0300, Mikhail Kshevetskiy wrote:
> In the an7581 case
>  * gpio47 and pcie_reset0 shares pin 60,
>  * gpio48 and pcie_reset1 shares pin 61,
>  * gpio49 and pcie_reset2 shares pin 62.
> but current driver treat them as pins 61--63. This is wrong.
> 
> Also current an7581 pinmux implementation have following issues:
>  * current pcie_reset pin function actually sets corresponding
>    pins as gpios.
>  * there is no proper way to set pcie_reset pins as gpios.
>  * there is no way to set pcie_reset pins as pwm.
> 
> This patch fixes above issues. Also device tree binding schema
> was updated.

Same comment.

Please run scripts/checkpatch.pl on the patches and fix reported
warnings. After that, run also 'scripts/checkpatch.pl --strict' on the
patches and (probably) fix more warnings. Some warnings can be ignored,
especially from --strict run, but the code here looks like it needs a
fix. Feel free to get in touch if the warning is not clear.

Best regards,
Krzysztof