RE: [PATCH v9 04/12] reset: realtek: Add RTD1625-ISO reset controller driver

[Yu-Chun Lin [林祐君]]

Hi Philipp,

> 
> On Do, 2026-06-25 at 10:05 +0000, Yu-Chun Lin [林祐君] wrote:
> > Hi Philipp,
> >
> > > On Mi, 2026-06-24 at 19:29 +0800, Yu-Chun Lin wrote:
> > > > From: Cheng-Yu Lee <cylee12@xxxxxxxxxxx>
> > > >
> > > > Add support for the ISO (Isolation) domain reset controller on the
> > > > Realtek
> > > > RTD1625 SoC.
> > > >
> > > > The reset controller shares the same register space with the ISO
> > > > clock controller. To handle this shared register space, the reset
> > > > driver is implemented as an auxiliary driver. It will be
> > > > instantiated and probed via the auxiliary bus by the RTD1625-ISO clock
> controller driver.
> > > >
> > > > Signed-off-by: Cheng-Yu Lee <cylee12@xxxxxxxxxxx>
> > > > Co-developed-by: Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
> > > > Signed-off-by: Yu-Chun Lin <eleanor.lin@xxxxxxxxxxx>
> > > > ---
> > > > Changes in v9:
> > > > - Extract reset-related code from the previous clock driver patch
> > > > (formerly patch 9 in v8).
> > > > ---
> > > >  drivers/reset/realtek/Makefile            |  2 +-
> > > >  drivers/reset/realtek/reset-rtd1625-iso.c | 99
> > > > +++++++++++++++++++++++
> > > >  2 files changed, 100 insertions(+), 1 deletion(-)  create mode
> > > > 100644 drivers/reset/realtek/reset-rtd1625-iso.c
> > > >
> > > > diff --git a/drivers/reset/realtek/Makefile
> > > > b/drivers/reset/realtek/Makefile index c3f605ffb11c..9007c9d5683b
> > > > 100644
> > > > --- a/drivers/reset/realtek/Makefile
> > > > +++ b/drivers/reset/realtek/Makefile
> > > > @@ -1,3 +1,3 @@
> > > >  # SPDX-License-Identifier: GPL-2.0-only
> > > >  obj-$(CONFIG_RESET_RTK_COMMON) += reset-rtk-common.o
> > > > -obj-$(CONFIG_RESET_RTD1625) += reset-rtd1625-crt.o
> > > > +obj-$(CONFIG_RESET_RTD1625) += reset-rtd1625-crt.o
> > > > +reset-rtd1625-iso.o
> > >
> > > Is there any benefit to these two being separate modules?
> > > I suggest you merge them into one: reset-rtd1625.o
> > >
> >
> > If I merge them into a single 'reset-rtd1625' module, both the 'crt'
> > and 'iso' clock drivers would trigger the probe process for the same
> > reset driver name, which would lead to a duplicate driver registration
> > error.
> 
> What do you mean by duplicate driver registration error?
> 
> There would only be one auxiliary_driver, with support for all three
> auxiliary_device_id's.
> 
> 
> regards
> Philipp

Ah, I understand what you mean now.

Previously, I only merged them in the Makefile but left two separate
'module_auxiliary_driver()' registrations in the C code, which caused the
duplicate registration error.

Following your suggestion, I will refactor the reset drivers into a single
'auxiliary_driver' entry with a single 'id_table' to
differentiate between the crt, iso, and iso_s reset types.

Best Regards,
Yu-Chun