Re: [PATCH 0/4] staging: octeon: Improve initialization error handling

From: Dan Carpenter

Date: Mon Jun 29 2026 - 03:28:52 EST


On Sun, Jun 28, 2026 at 12:31:23PM +0530, Prashant Rahul wrote:
> Hi all,
>
> The TX and RX initialization paths currently call panic() on some
> initialization failures. Instead, these failures should be reported back
> to the probe function so that it can unwind any resources acquired during
> initialization and fail gracefully.
>
> This series replaces those panic() calls with proper error logging, propagates
> the errors to the probe function, and adds the necessary cleanup to avoid
> leaving the driver in a partially initialized state.
>
> This is my first time working with drivers, so please let me know if I
> have made any mistakes.
>
> Thank you! :3
>
> Signed-off-by: Prashant Rahul <prashantrahul23@xxxxxxxxx>
> ---

You need to say when you haven't tested your code.

You need to say when you're using AI to write patches. There is
a format for it.
Documentation/process/coding-assistants.rst

regards,
dan carpenter