Re: [PATCH] dt-bindings: mailbox: qcom: Add IPQ5210 APCS compatible
From: Krzysztof Kozlowski
Date: Mon Jun 29 2026 - 03:33:05 EST
On Mon, Jun 29, 2026 at 10:10:46AM +0530, Varadarajan Narayanan wrote:
> Add the APCS mailbox compatible for the IPQ5210 SoC. It uses the IPQ6018
> APCS mailbox compatible as a fallback, so document the valid compatible
> string combination in the binding.
>
> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@xxxxxxxxxxxxxxxx>
> ---
> no cover letter contents, it is a single patch
> ---
> Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> index 1b4ef0688ca7..39bc374300c3 100644
> --- a/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> +++ b/Documentation/devicetree/bindings/mailbox/qcom,apcs-kpss-global.yaml
> @@ -19,6 +19,7 @@ properties:
> - items:
> - enum:
> - qcom,ipq5018-apcs-apps-global
> + - qcom,ipq5210-apcs-apps-global
> - qcom,ipq5332-apcs-apps-global
> - qcom,ipq5424-apcs-apps-global
> - qcom,ipq8074-apcs-apps-global
>
> ---
> base-commit: 533704f3c28c3f5f9e2542aa3a6a326c32e6f5c0
> change-id: 20260625-mailbox-01f977bcceec
> prerequisite-change-id: 20260625-apss-clk-ed39c40ed468:v1
> prerequisite-patch-id: d9efdd8a09b028b1343243c5f0e78cf3e8b1e253
Same author, just squash them.
I already complained within Qualcomm about this more than once. On the
mailing list, on the internal company-wide open-source channel and in
person now when I was in Hyderabad.
Repeating the same is waste of my time, easier to have blanket NAK on
your patches.
NAK
Best regards,
Krzysztof