Re: [PATCH v5 0/5] HID: asus: security fixes and more hardware support

[Jiri Kosina]

On Fri, 19 Jun 2026, Denis Benato wrote:

> Hi all,
> 
> I have added support for controlling the (way too bright) XG mobile
> LEDs in hid-asus and added the i2c version of already supported
> hardware that was probed only when it's a USB: these are two separate
> features changes and are the only two that are not fixes for
> pre-existing issue (see below).
> 
> Auto-review bot has spotted a bunch of pre-existing problems alongside
> problems in my own code therefore at this point I am going to fix the
> more problems I can and including those fixes and improvements in this
> patchset.
> 
> For v4 I decided to follow Antheas' suggestion of reusing the existing
> workqueue and by making it more generic I solved a good bunch of issues.
> 
> The v5 iteration is simply me fixing a bunch of bugs in new code spotted
> by the bot. Thanks for providing such a useful tool!
> 
> On a side node this patchset has a few more warnings: specifically
> "WARNING: Prefer kzalloc_obj over kzalloc with sizeof" but it's a false
> positive as that would introduce sleeping calls in atomic contexts.

Denis,

thanks. Could you please flag which patches you'd prefer to go in still 
for 7.1 and which ones are not critical and could wait for 7.2? The whole 
lot is quite big.

Thanks,

-- 
Jiri Kosina
SUSE Labs