Re: [PATCH v2 2/3] arm64: dts: qcom: Add HP EliteBook X G2q 14 AI

[Konrad Dybcio]

On 6/27/26 9:06 PM, Jason Pettit wrote:
> On Fri, 26 Jun 2026 13:26:14 +0200, Konrad Dybcio wrote:
>> I would assume it's simply not present (as every SMB2370 is a separate
>> physical chip) - perhaps we should just add status = "disabled" in the
>> DTSI file and enable the nodes on an as-needed basis
> 
> Apologies for the duplicate. My earlier copy of this reply went out with a
> misconfigured sender identity from a local mail setup issue. Resending it
> cleanly.
> 
> I'm not sure if the chip is populated, but I tested whether it enumerates.
> With smb2370_l enabled, the SID-11 SPMI device (2-0b on the SPMI-2 bus)
> fails to probe:
> 
>   spmi spmi-2: pmic_arb_check_chnl_status_v1: 0xb 0x104: transaction failed (0x3)
>   pmic-spmi 2-0b: probe with driver pmic-spmi failed with error -5
> 
> The SPMI PMIC arbiter can't complete a transaction to SID 0xb, so pmic-spmi
> can't read it and the eusb2 repeater doesn't bind pmic@b (only pmic@9 and
> pmic@a come up). I keep it disabled.
> 
> Defaulting that in smb2370.dtsi would touch the shared file instead of just
> this board,

That's preferred, and in our favor, since there's only two boards
upstream today (Glymur CRD and Mahua CRD) that include this, so there's
not a lot to fixup manually

Konrad

> so I've left the override here for now. The comment in v3 will
> be updated to read:
> 
> 	/*
> 	 * smb2370.dtsi enables all three repeaters by default; SID-11
> 	 * (smb2370_l) does not enumerate on this board, so override it back
> 	 * to disabled.
> 	 */
> 
> Thanks,
> Jason