Re: [PATCH v2 0/4] hwspinlock: add summary in debugfs

[Andy Shevchenko]

On Mon, Jun 29, 2026 at 10:57:14AM +0200, Wolfram Sang wrote:

...

> > --- a/drivers/hwspinlock/hwspinlock_core.c
> > +++ b/drivers/hwspinlock/hwspinlock_core.c
> > @@ -16,7 +16,7 @@
> >  #include <linux/types.h>
> >  #include <linux/err.h>
> >  #include <linux/jiffies.h>
> > -#include <linux/radix-tree.h>
> > +#include <linux/xarray.h>
> 
> According to some quick grepping, there are 102 users of XArray
> including this header and 423 users which are not including this header.
> Do you think this is a useful improvement to add the header directly
> (per subsystem to keep the number of patches limited)?

My 2c that we should follow the IWYU principle. XArray header is not generic
enough that we may rely on something else to provide it. And hence I'm fully
with including that explicitly. That mentioned users simply neglected the
principle and I consider that as an inconvenience.

-- 
With Best Regards,
Andy Shevchenko