Re: [PATCH] drm/imagination: make pvr_fw_trace_init_mask_ops static

[Alessio Belle]

On Tue, 2026-06-23 at 11:53 +0100, Ben Dooks wrote:
> The pvr_fw_trace_init_mask_ops is not used outside pvr_fw_trace.c
> so make it static to avoid the following sparse warning:
> 
> drivers/gpu/drm/imagination/pvr_fw_trace.c:74:31: warning: symbol 'pvr_fw_trace_init_mask_ops' was not declared. Should it be static?
> 
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>

Reviewed-by: Alessio Belle <alessio.belle@xxxxxxxxxx>

Thanks,
Alessio

> ---
>  drivers/gpu/drm/imagination/pvr_fw_trace.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/imagination/pvr_fw_trace.c b/drivers/gpu/drm/imagination/pvr_fw_trace.c
> index 6bb5baa6c41b..805d9f9bc1dd 100644
> --- a/drivers/gpu/drm/imagination/pvr_fw_trace.c
> +++ b/drivers/gpu/drm/imagination/pvr_fw_trace.c
> @@ -71,7 +71,7 @@ pvr_fw_trace_init_mask_set(const char *val, const struct kernel_param *kp)
>  	return 0;
>  }
>  
> -const struct kernel_param_ops pvr_fw_trace_init_mask_ops = {
> +static const struct kernel_param_ops pvr_fw_trace_init_mask_ops = {
>  	.set = pvr_fw_trace_init_mask_set,
>  	.get = param_get_hexint,
>  };