Re: [PATCH] net: stmmac: fix missed le32_to_cpu()

[Ben Dooks]

On 25/06/2026 08:07, Maxime Chevallier wrote:
> On 6/25/26 04:22, Jakub Kicinski wrote:
> > On Mon, 22 Jun 2026 19:51:39 +0200 Maxime Chevallier wrote:
> > > Hi Ben,
> > >
> > > On 6/22/26 16:37, Ben Dooks wrote:
> > > > The print in ndesc_display_ring() sends the des2 and des3
> > > > to the pr_info() without passing them through the relevant
> > > > conversion to cpu order.
> > > >
> > > > Fix the (prototype) sparse warnings by using le32_to_cpu():
> > > > drivers/net/ethernet/stmicro/stmmac/norm_desc.c:258:17: warning: incorrect type in argument 6 (different base types)
> > > > drivers/net/ethernet/stmicro/stmmac/norm_desc.c:258:17:    expected unsigned int
> > > > drivers/net/ethernet/stmicro/stmmac/norm_desc.c:258:17:    got restricted __le32 [usertype] des2
> > > > drivers/net/ethernet/stmicro/stmmac/norm_desc.c:258:17: warning: incorrect type in argument 7 (different base types)
> > > > drivers/net/ethernet/stmicro/stmmac/norm_desc.c:258:17:    expected unsigned int
> > > > drivers/net/ethernet/stmicro/stmmac/norm_desc.c:258:17:    got restricted __le32 [usertype] des3
> > > >
> > > > Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> > >
> > > I agree on the principle, but this isn't a fix so this'll have to wait
> > > until net-next re-opens :)
> >
> > Humpf, why are we not seeing this on x86 allmodconfig ? 🤔️
> >
> > $ make C=1 W=1 drivers/net/ethernet/stmicro/stmmac/norm_desc.o
> >    DESCEND objtool
> >    CC [M]  drivers/net/ethernet/stmicro/stmmac/norm_desc.o
> >    CHECK   drivers/net/ethernet/stmicro/stmmac/norm_desc.c
> > $
>
> Heh good point indeed !
>    
> > > > Fix the (prototype) sparse warnings by using le32_to_cpu():
>
> Ben, what's this "prototype" sparse ? a custom tool of yours that
> you used to find that ?

I have an RFC to add variadic and thus also printf/scanf formatting
to sparse. This is waiting on review after the original got re-worked
to add scanf and a few other bug-fixed and shuffles.

Ref: https://marc.info/?l=linux-sparse&m=178185274600679&w=2


--
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html