Re: [PATCH] media: atomisp: fix CAS scaler descriptor leaks

From: Andy Shevchenko

Date: Mon Jun 29 2026 - 07:22:08 EST


On Mon, Jun 29, 2026 at 11:30:40AM +0300, Dan Carpenter wrote:
> On Sat, Jun 27, 2026 at 02:01:51PM +0800, Dawei Feng wrote:

...

> free_output_stage:
> if (need_scalar) {
> kfree(mycs->is_output_stage);
> mycs->is_output_stage = NULL;
> }
> free_scalar_binary:
> if (need_scalar) {
> kfree(mycs->yuv_scaler_binary);
> mycs->yuv_scaler_binary = NULL;
> }

If we go this way, double check that the checks are needed as we have kfree()
to be NULL-aware.

--
With Best Regards,
Andy Shevchenko