Re: [PATCH 02/32] powercap: Stop using 32-bit MSR interfaces

[Jürgen Groß]

On 29.06.26 13:25, Ingo Molnar wrote:
> * Juergen Gross <jgross@xxxxxxxx> wrote:
>
> > The 32-bit MSR interfaces rdmsr_safe() and wrmsr_safe() are planned to
> > be removed. Use the related 64-bit variants instead.
> >
> > Drop a pointless initializer.
>
> Was the initializer really 'pointless'? IIRC it suppressed a build warning
> on 32-bit builds, at least in some past iterations of these APIs.

I don't see the connection to 32-bit builds. Either the uninitialized
variable is a problem or not. And I don't see why "l" didn't need an initial
value (it is modified in this function only via a "&=" operation, so some
bits would still be random in case it is seen not to be set by rdmsr_safe()).

In reality it should never be a problem, as rdmsr_safe() will always set both
output variables to a value (0 in case of error, MSR contents else).

> So maybe this should say: 'Drop initializer that became pointless'?

I don't think so.


Juergen

Attachment: OpenPGP_0xB0DE9DD628BF132F.asc
Description: OpenPGP public key

Attachment: OpenPGP_signature.asc
Description: OpenPGP digital signature