Re: [PATCH v4 0/5] ASoC: Intel: Convert locking to guard()/scoped_guard()

[Bui Duc Phuc]

On Mon, Jun 29, 2026 at 3:29 PM Cezary Rojewski
<cezary.rojewski@xxxxxxxxx> wrote:
>
> On 6/26/2026 10:28 AM, phucduc.bui@xxxxxxxxx wrote:
> > From: bui duc phuc <phucduc.bui@xxxxxxxxx>
> >
> > Hi all,
> >
> > This series converts mutex and spinlock handling in Intel ASoC drivers
> > to use guard()/scoped_guard() helpers.
> >
> > Most changes are straightforward conversions intended to simplify lock
> > handling and cleanup paths, with no intended functional changes.
> >
> > The series has been compile-tested only.
> The patchset looks very good, for all:
>
> Reviewed-by: Cezary Rojewski <cezary.rojewski@xxxxxxxxx>
>
> Can provide Tested-by: tag but not today - tomorrow, as my CI is in the
> middle of waking up after a routine maintenance.
>
>
> Kind regards,
> Czarek

Hi Czarek,

Thanks, I understand. No problem at all.

The only thing I'm still a bit concerned about is splitting the kfree
and guard() changes into two patches.
Since the guard() conversion is mainly there to eliminate the goto
labels, testing them separately might
introduce issues that wouldn't exist when both patches are applied together.

By the way, I'm curious about your CI. What kinds of tests does it cover?
For example, can it detect regressions related to audio functionality
only, or is it also able to validate
audio quality? I imagine things that require someone to actually
listen to the output would be difficult
to automate.

Best regards,
Phuc