Re: [PATCH v4 0/2] iio: magnetometer: add support for Melexis MLX90393
From: Andy Shevchenko
Date: Mon Jun 29 2026 - 09:57:33 EST
On Sat, Jun 27, 2026 at 03:25:17PM +0530, Nikhil Gautam wrote:
> Hi,
>
> This series adds initial Industrial I/O subsystem support for the
> Melexis MLX90393 3-axis magnetometer and temperature sensor.
>
> The MLX90393 supports both I2C and SPI interfaces. This series
> implements support for the I2C interface while keeping the driver
> structure transport-independent to simplify future SPI support.
>
> The device uses a command-based communication protocol rather than a
> conventional register-addressed interface. A small transport abstraction
> layer is therefore used instead of regmap to share the common sensor
> logic between the current I2C implementation and future SPI support.
>
> Currently supported features:
>
> * Raw magnetic field measurements for X/Y/Z axes
> * Raw temperature measurements
> * Configurable gain/scale selection
> * Configurable oversampling ratio
> * Direct mode operation through the IIO subsystem
> * I2C interface support
>
> The driver has been tested on Raspberry Pi 5 hardware using an
> MLX90393 sensor connected over I2C. Magnetic field and temperature
> measurements were verified through the IIO sysfs interface.
...
> v3: https://lore.kernel.org/linux-iio/20260627005843.7786-3-nikhilgtr@xxxxxxxxx/T/#u
> v2: https://lore.kernel.org/linux-iio/20260618160141.11409-1-nikhilgtr@xxxxxxxxx/T/#t
> v1: https://lore.kernel.org/linux-iio/20260510191010.155380-1-nikhilgtr@xxxxxxxxx/
No, do not issue versions so often, especially for a new driver. *Minimum* of
one week must be between two versions.
NAK. Please, go to v3, study, address, and settle down the comments given there.
--
With Best Regards,
Andy Shevchenko