Re: [PATCH v5 0/3] iio: adc: Add support for TI ADS1110 to ti-ads1100 driver

[David Lechner]

On 6/28/26 2:43 PM, Jakub Szczudlo wrote:
> Add support for the TI ADS1110 to the existing ADS1100 ADC IIO driver.
> The ADS1110 is pin-to-pin compatible with the ADS1100 while providing
> higher resolution and an internal voltage reference. This patch series
> extends driver support for ADS1110, updates device tree bindings and
> Kconfig text, and improves the overall hardware description for the
> TI ADS1100 family.
> 
> Tested on: Raspberry pi 3b+ with 7.0 stable kernel
> 
> Signed-off-by: Jakub Szczudlo <jakubszczudlo40@xxxxxxxxx>
> 
> ---
> V4 -> V5:
> - Correct pm macros to be more generic
> - fix variables ordering in new functions
> - delete unnecessary casts

Either this changelog is incomplete or some of my comments on v4
were not addressed. (If you disagree with comments, that is fine,
just reply to them with your reasoning. If you don't reply, then
we assume you agree with them and expect to see the changes here.)

> - Link to v4: https://lore.kernel.org/linux-iio/20260622221550.374235-1-jakubszczudlo40@xxxxxxxxx/
> 
> V3 -> V4:
> - make fixes patch the first change in the series
> - correct error handling when short read
> - use ACQUIRE macros from pm_runtime.h in new functions
> - Link to v3: https://lore.kernel.org/linux-iio/20260613190957.654798-1-jakubszczudlo40@xxxxxxxxx/
> 
> V2 -> V3:
> - clean patch from unreleated changes
> - divide adding support for ads1110 into separate patch
> - add missing changelog
> - Link to v2: https://lore.kernel.org/linux-iio/20260607183542.368184-1-jakubszczudlo40@xxxxxxxxx/
> 
> V1 -> V2:
> - go from creating new driver to extending ADS1100 driver to support ADS1110
> - Link to v1: https://lore.kernel.org/linux-iio/20260527164312.355729-1-jakubszczudlo40@xxxxxxxxx/
> 
> Jakub Szczudlo (3):
>   iio: adc: Fix incorrect reading when datarate changed in single mode
>   dt-bindings: iio: adc: ti,ads1100: add support for ADS1110
>   iio: adc: Add ti-ads1110 support to ti-ads1100 driver
> 
>  .../bindings/iio/adc/ti,ads1100.yaml          |  10 +-
>  drivers/iio/adc/Kconfig                       |   9 +-
>  drivers/iio/adc/ti-ads1100.c                  | 145 +++++++++++++++---
>  3 files changed, 135 insertions(+), 29 deletions(-)
>