Re: [PATCH v2 01/15] media: i2c: os05b10: Use pm_runtime_get_if_active() when applying controls

[Mehdi Djait]

Hi Tarang,

On Wed, Mar 25, 2026 at 05:13:47PM +0530, Tarang Raval wrote:
> os05b10_set_ctrl() currently uses pm_runtime_get_if_in_use() to decide
> whether controls should be applied to hardware.
> 
> This is not correct for the intended behavior. If the runtime PM usage
> count is 0 while the device is still active, pm_runtime_get_if_in_use()
> returns 0 and the control update is skipped, leaving the software state
> updated but not the hardware state.
> 
> Use pm_runtime_get_if_active() instead so controls are applied whenever
> the device is runtime-active, regardless of the current usage count.
> 
> Cc: stable@xxxxxxxxxxxxxxx
> Fixes: 3aa9296a23ec4("media: i2c: add os05b10 image sensor driver")

A space is missing here after the commit hash.
See https://docs.kernel.org/process/submitting-patches.html

checkpatch will warn you about it.

with that:
Reviewed-by: Mehdi Djait <mehdi.djait@xxxxxxxxxxxxxxx>

> Signed-off-by: Tarang Raval <tarang.raval@xxxxxxxxxxxxxxxxx>
> ---
>  drivers/media/i2c/os05b10.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/i2c/os05b10.c b/drivers/media/i2c/os05b10.c
> index e0453c988e4a..5da5b7d21f31 100644
> --- a/drivers/media/i2c/os05b10.c
> +++ b/drivers/media/i2c/os05b10.c
> @@ -531,7 +531,7 @@ static int os05b10_set_ctrl(struct v4l2_ctrl *ctrl)
>  			return ret;
>  	}
>  
> -	if (pm_runtime_get_if_in_use(os05b10->dev) == 0)
> +	if (pm_runtime_get_if_active(os05b10->dev) == 0)

small nit: how about
	if (!pm_runtime_get_if_active(os05b10->dev))

consistent with other drivers using this call but really not important,
up to you if you want to change it.

--
Kind Regards
Mehdi Djait