Re: [PATCH] posix_acl: remove useless code

[Jori Koolstra]

On Mon, Jun 29, 2026 at 04:45:54PM +0100, Luis Henriques wrote:
> This is just a trivial clean-up: it removes an unnecessary return branch.
> 
> Signed-off-by: Luis Henriques <luis@xxxxxxxxxx>
> ---
>  fs/posix_acl.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/posix_acl.c b/fs/posix_acl.c
> index b4bfe4ddf64e..6df5de23aac4 100644
> --- a/fs/posix_acl.c
> +++ b/fs/posix_acl.c
> @@ -740,8 +740,6 @@ static int posix_acl_fix_xattr_common(const void *value, size_t size)
>  	count = posix_acl_xattr_count(size);
>  	if (count < 0)
>  		return -EINVAL;
> -	if (count == 0)
> -		return 0;
>  
>  	return count;
>  }

Right, well spotted. Feel free to add:

Reviewed-by: Jori Koolstra <jkoolstra@xxxxxxxxx>