Re: [PATCH] clk: qcom: enable ALWAYS_ON for titan_top_gdsc

[Vladimir Zapolskiy]

Hi Brian,

On 6/29/26 18:27, Brian Masney wrote:
> Hi Vladimir,
>
> On Mon, Jun 29, 2026 at 04:00:46PM +0300, Vladimir Zapolskiy wrote:
> > commenting the series I was also directed by Konrad's review comment on it.
> > In addition one problem, which I immediate observe, is that camcc_sc8280xp_desc
> > misses the necessary .use_rpm flag, can you please do me a favour and test
> > my series plus the add-on change below?
> >
> > diff --git a/drivers/clk/qcom/camcc-sc8280xp.c b/drivers/clk/qcom/camcc-sc8280xp.c
> > index 18f5a3eb313e..a15e9754bfb2 100644
> > --- a/drivers/clk/qcom/camcc-sc8280xp.c
> > +++ b/drivers/clk/qcom/camcc-sc8280xp.c
> > @@ -2995,6 +2995,8 @@ static const struct qcom_cc_desc camcc_sc8280xp_desc = {
> >   	.num_resets = ARRAY_SIZE(camcc_sc8280xp_resets),
> >   	.gdscs = camcc_sc8280xp_gdscs,
> >   	.num_gdscs = ARRAY_SIZE(camcc_sc8280xp_gdscs),
> > +	.use_rpm = true,
> > +	.cc_gdsc = &titan_top_gdsc,
> >   };
> >   static const struct of_device_id camcc_sc8280xp_match_table[] = {
>
> I tried with this initially, however it fails with:
>
> [    8.193803] camcc-sc8280xp ad00000.clock-controller: Unbalanced pm_runtime_enable!
>
> I see that pm_runtime_enable() is called from common.c when use_rpm is
> enabled. So I removed all of that from camcc-sc8280xp.c with the
> attached patch.

I believe the updated change is correct.

> It still fails with:
>
> [    8.204595] camcc-sc8280xp ad00000.clock-controller: probe with driver camcc-sc8280xp failed with error -22
>
> I suspect the use_rpm flag requires a more thorough migration.

Likely it does. Unfortunately I don't have an sc8280xp powered board to get
more information about this particular failure, but please give me some time
to check, if I can reproduce the same issue on SM8250/RB5, if its CAMCC is
added under the runtime PM framework.

Thank you for the performed testing.

--
Best wishes,
Vladimir