Re: [PATCH v3 4/4] iio: dac: ad3530r: Add support for AD3532R/AD3532

[Jonathan Cameron]

On Mon, 29 Jun 2026 16:31:07 +0800
Kim Seer Paller <kimseer.paller@xxxxxxxxxx> wrote:

> The AD3532R/AD3532 is a 16-channel, 16-bit voltage output DAC with a
> dual-bank register architecture (bank 0 at 0x1000 for channels 0-7,
> bank 1 at 0x3000 for channels 8-15). It shares similar functionality
> with AD3530R (channel configuration, LDAC triggering, powerdown control),
> the main difference being the register address map due to the dual-bank
> architecture, handled by table-driven helpers.
> 
> Add AD3532R-specific register definitions, channel specs, per-bank
> register arrays, a dedicated ad3532r_set_dac_powerdown(), and per-chip
> regmap_config to limit debugfs-exposed register space to each variant's
> actual address range.
The change to add the ability to provide different regmap configs
would ideally have been a precursor patch (a noop easy to review one).

Then this patch would have been just adding the new device support,
not a small refactor as well.

Otherwise, I didn't see anything to add to what Andy has called out

Thanks

Jonathan