Re: [PATCH v2 0/2] iio: adc: ad7779: Remove dead code and redundant error message

[Jonathan Cameron]

On Sun, 28 Jun 2026 19:13:50 +0200
Joshua Crofts <joshua.crofts1@xxxxxxxxx> wrote:

> On Sun, 28 Jun 2026 14:57:32 +0000
> Moksh Panicker <mokshpanicker.7@xxxxxxxxx> wrote:
> 
> > These two patches address review feedback from Joshua Crofts on the
> > ad7779 driver:
> > 
> > 1. Remove an unused completion field that was initialized but never 
> > waited on or signaled anywhere in the driver.
> > 
> > 2. Remove a redundant dev_err_probe() wrapper around devm_request_irq(), 
> > which already calls dev_err_probe() internally.
> > 
> > Moksh Panicker (2):
> >   iio: adc: ad7779: Remove unused completion field
> >   iio: adc: ad7779: Remove redundant dev_err_probe() after
> >     devm_request_irq()
> > 
> >  drivers/iio/adc/ad7779.c | 5 +----
> >  1 file changed, 1 insertion(+), 4 deletions(-)
> >   
> 
> You forgot to pull my Reviewed-by tags, no need to resend:
> 
> Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>

Hi Moksh,

Generally slow down a little.  You may well have gotten
additional review on v1 if you'd waited longer and
save both a little of your time and that of reviewers.

For even a simple series like this I'd wait a few days,
or better still 1 week between early versions.  It gets
more relaxed if the code is already well reviewed and
we are just dealing with final tweaks.

Thanks,

Jonathan