Re: [PATCH v2] usb: dwc3: fix dwc3_readl() and dwc3_writel() calls in dwc3_ulpi_setup()

[Thinh Nguyen]

On Mon, Jun 29, 2026, Ben Dooks wrote:
> The dwc3_ulpi_setup() calls the register read and write calls with
> dwc3->regs when both these calls take the dwc3 structure directly.
> 
> Chnage these two calls to fix the following sparse warning, and
> possibly a nasty bug in the dwc3_ulpi_setup() code:
> 
> drivers/usb/dwc3/core.c:796:45: warning: incorrect type in argument 1 (different address spaces)
> drivers/usb/dwc3/core.c:796:45:    expected struct dwc3 *dwc
> drivers/usb/dwc3/core.c:796:45:    got void [noderef] __iomem *regs
> drivers/usb/dwc3/core.c:798:40: warning: incorrect type in argument 1 (different address spaces)
> drivers/usb/dwc3/core.c:798:40:    expected struct dwc3 *dwc
> drivers/usb/dwc3/core.c:798:40:    got void [noderef] __iomem *regs
> 
> Cc: stable@xxxxxxxxxx
> Fixes: dcdc3f399e3b ("usb: dwc3: Support USB3340x ULPI PHY high-speed negotiation.")

This patch should be v3, and the Fixes tag should be pointing to 
9accc68b1cf0 ("usb: dwc3: Add dwc pointer to dwc3_readl/writel")

Thanks,
Thinh

> Acked-by: Thinh Nguyen <Thinh.Nguyen@xxxxxxxxxxxx>
> Signed-off-by: Ben Dooks <ben.dooks@xxxxxxxxxxxxxxx>
> ---
> v2: add fixes and cc to stable
> ---
>  drivers/usb/dwc3/core.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>