Re: [PATCH v7 0/5] selftests/mm: refactor pkey helpers and fix mmap error handling

From: Hongfu Li

Date: Mon Jun 29 2026 - 21:48:49 EST


Hi,

> > The main changes in this series are to refactor shared tracing and assertion
> > helpers into a common file, unify both pkey selftests on pkey_assert() and
> > per-test tracing for consistent diagnostics, and add missing mmap() return
> > checks with MAP_FAILED used throughout for readability and consistency.
>
> Thanks.
>
> >
> > ...
> >
> > tools/testing/selftests/mm/pkey-helpers.h | 4 +-
> > tools/testing/selftests/mm/pkey-powerpc.h | 2 +-
> > .../selftests/mm/pkey_sighandler_tests.c | 81 ++++++++--------
> > tools/testing/selftests/mm/pkey_util.c | 86 +++++++++++++++++
> > tools/testing/selftests/mm/protection_keys.c | 95 ++-----------------
> > 5 files changed, 141 insertions(+), 127 deletions(-)
>
> Unfortunately MAINTAINERS and get_maintainer are often useless in
> selftests. In this case, I expect the people who wrote and work on the
> pkey tests don't know that this patchset exists!
>
> Poking around with git-blame or git-log
> tools/testing/selftests/mm/pkey* will show who should be cc'ed.
>
> So can I ask that you figure that out and send out a v8?

Thank you for the reminder and for taking the time to review.

I will use git blame and git log on tools/testing/selftests/mm/pkey* to
identify the relevant developers and CC them in v8.

Best regards,
Hongfu