Re: [PATCH v7 023/120] x86/cpu/centaur: Use parsed CPUID(0xc0000001)

[Borislav Petkov]

On Thu, May 28, 2026 at 05:37:45PM +0200, Ahmed S. Darwish wrote:
> Use parsed CPUID(0xc0000001).

You already said that in the title :)

> 
> Beside the CPUID parser centralization benefits, this allows using the

s/this allows using/use/

>From Documentation/process/submitting-patches.rst:

 "Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
  instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
  to do frotz", as if you are giving orders to the codebase to change
  its behaviour."

> auto-generated x86-cpuid-db data types, and their full C99 bitfields,
> instead of doing ugly bitwise operations on the CPUID output.
> 
> Keep the x86_capability[] CPUID(0xc0000001).EDX assignment.  It will be
> removed once X86_FEATURE translation is integrated into the CPUID model.
> 
> Signed-off-by: Ahmed S. Darwish <darwi@xxxxxxxxxxxxx>
> ---
>  arch/x86/kernel/cpu/centaur.c | 25 +++++++++----------------
>  1 file changed, 9 insertions(+), 16 deletions(-)

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette