Re: [PATCH v5 2/4] iomap: factor out iomap_dio_bio_release_pages helper

[Christoph Hellwig]

On Mon, Jun 29, 2026 at 08:01:22PM +0800, Fengnan Chang wrote:
> Extract bio page-release logic from __iomap_dio_bio_end_io() into a
> helper taking (bio, dio_flags, error) so the upcoming simple direct I/O
> path can reuse it without a struct iomap_dio.

The first two branches can't happen for the simple code, so is this
really a useful abstraction?  I think just open coding the
bio_check_pages_dirty / bio_release_pages might end up simpler.