Re: [PATCH 1/2] dt-bindings: display: panel: Add Novatek NT36536
From: Krzysztof Kozlowski
Date: Tue Jun 30 2026 - 03:46:20 EST
On Tue, Jun 30, 2026 at 10:34:38AM +0800, Pengyu Luo wrote:
> NT36536 is a driver IC used to drive MIPI-DSI panels. It is found in
> LENOVO Legion Y700 Gen4 with a 10-bit CSOT panel.
>
> Signed-off-by: Pengyu Luo <mitltlatltl@xxxxxxxxx>
> ---
> .../display/panel/novatek,nt36536.yaml | 90 +++++++++++++++++++
> 1 file changed, 90 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/novatek,nt36536.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/novatek,nt36536.yaml b/Documentation/devicetree/bindings/display/panel/novatek,nt36536.yaml
> new file mode 100644
> index 000000000000..f854fc99ba81
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/novatek,nt36536.yaml
> @@ -0,0 +1,90 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/novatek,nt36536.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Novatek NT36536 based DSI display Panels
> +
> +maintainers:
> + - Pengyu Luo <mitltlatltl@xxxxxxxxx>
> +
> +description:
> + The Novatek NT36536 is a generic DSI Panel IC used to drive dsi
> + panels. Support video mode panels from China Star Optoelectronics
> + Technology (CSOT).
> +
> +allOf:
> + - $ref: panel-common-dual.yaml#
Nothing in commit msg or description explains why is this a dual-link?
Judging by example this was intentional, so it should be mentioned
somewhere.
With this improved:
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
Best regards,
Krzysztof