Re: [PATCH] ata: sata_dwc_460ex: use platform_get_irq()

[Damien Le Moal]

On 6/30/26 17:52, Rosen Penev wrote:
>>> Inside ifdef, that is probably why Sashiko did not catch this new warning.
>>>
>>> Rosen, I suggest that you use dev->of_node directly within the ifdef, and drop the local np variable.
>> device_property_present is probably better. But yeah. I'll whip up a v2.
> thinking about this some more. Should use IS_ENABLED to prevent hiding
> this code from the compiler.

What code are you talking about ?
What is in the #ifdef CONFIG_SATA_DWC_OLD_DMA ?
CONFIG_SATA_DWC_OLD_DMA is determined automatically by Kconfig. So this is not
hidding anything and why I did not see the warning in my compile tests
(CONFIG_SATA_DWC_OLD_DMA was enabled for me). The report was for Sparc, and
CONFIG_SATA_DWC_OLD_DMA was disabled so the unused variable warning showed up.


-- 
Damien Le Moal
Western Digital Research