Re: [tip: sched/urgent] sched/fair: Fix stale comments referring to removed CFS concepts

From: Peter Zijlstra

Date: Tue Jun 30 2026 - 05:13:20 EST


On Mon, Jun 29, 2026 at 11:13:14AM -0000, tip-bot2 for Zhan Xusheng wrote:
> The following commit has been merged into the sched/urgent branch of tip:
>
> Commit-ID: 17fdabfa3aeca3d07846a8d56ac0abf61b58bffd
> Gitweb: https://git.kernel.org/tip/17fdabfa3aeca3d07846a8d56ac0abf61b58bffd
> Author: Zhan Xusheng <zhanxusheng1024@xxxxxxxxx>
> AuthorDate: Mon, 29 Jun 2026 11:02:00 +08:00
> Committer: Ingo Molnar <mingo@xxxxxxxxxx>
> CommitterDate: Mon, 29 Jun 2026 13:11:52 +02:00
>
> sched/fair: Fix stale comments referring to removed CFS concepts
>
> A few comments still describe the pre-EEVDF CFS world:
>
> - sysctl_sched_base_slice is documented as "Minimal preemption
> granularity for CPU-bound tasks". That was the wording of the old
> sysctl_sched_min_granularity, renamed in commit e4ec3318a17f
> ("sched/debug: Rename sysctl_sched_min_granularity to
> sysctl_sched_base_slice"). Under EEVDF it is the default base time
> slice / request size (r_i) used to compute the virtual deadline, as
> documented in update_deadline().
>
> - Two comments still mention sched_slice(), which was removed when the
> fair class committed to EEVDF in commit 5e963f2bd465 ("sched/fair:
> Commit to EEVDF"). The dequeue-path comment should simply refer to
> the task's slice (se->slice); the forced-idle comment describes the
> slice accounting now performed by __entity_slice_used(), which is the
> function actually used right below it.
>
> No functional changes.
>
> Signed-off-by: Zhan Xusheng <zhanxusheng@xxxxxxxxxx>
> Signed-off-by: Ingo Molnar <mingo@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Link: https://patch.msgid.link/20260629030200.3165589-1-zhanxusheng@xxxxxxxxxx

This is comments, cannot be urgent. Also generates non-trivial conflicts
against the patches I just stuck in sched/core. So zapped this commit.