Re: [PATCH v2] drm/tegra: fix host1x_bo_pin leak in tegra_dc_pin error path
From: Greg KH
Date: Tue Jun 30 2026 - 05:20:11 EST
On Mon, Jun 29, 2026 at 02:59:05PM +0900, Mikko Perttunen wrote:
> On Monday, June 29, 2026 12:02 AM WenTao Liang wrote:
> > When map->chunks > 1 triggers an error, the function jumps to unpin
> > before storing the current map in state->map[i]. The unpin loop only
> > cleans up previously pinned planes (indices 0 through i-1), so the
> > current mapping returned by host1x_bo_pin is never released via
> > host1x_bo_unpin.
> >
> > Suggested-by: Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx>
> > Fixes: c6aeaf56f468 ("drm/tegra: Implement correct DMA-BUF semantics")
>
> This patch changes the code around the line, but doesn't look like it's
> the origin of the bug. Rather, I think commit
>
> 49f821919bb9d45de7f1cde6072de01d36235b5d
>
> is the origin.
>
> Aside from that,
>
> Reviewed-by: Mikko Perttunen <mperttunen@xxxxxxxxxx>
I did not suggest this, so please do not accept this patch.