Re: [PATCH 1/2] tracing: Embed 'char comm[16]' in a structure

[David Laight]

On Mon, 29 Jun 2026 16:26:34 -0400
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> On Fri, 26 Jun 2026 22:23:55 +0100
> David Laight <david.laight.linux@xxxxxxxxx> wrote:
> 
> \> --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -52,6 +52,7 @@
> >  #include <linux/sort.h>
> >  #include <linux/io.h> /* vmap_page_range() */
> >  #include <linux/fs_context.h>
> > +#include <linux/trace_printk.h>  
> 
> Left over debugging? ;-)

Possibly from a build where I'd taken it out of kernel.h.
I think this file needs that header from somewhere.
Probably for the prototypes for tracing_on() etc.
It really ought to have an explicit include rather than relying on
a 'proxy' include.

I did resolve a lot of those include issues by putting it into the
main trace headers (which is big an non-trivial).

	David

> 
> -- Steve