Re: [PATCH v2 3/7] gpu: nova-core: read vGPU mode from FSP via PRC protocol

[Alexandre Courbot]

On Tue Jun 23, 2026 at 4:43 AM JST, Zhi Wang wrote:
> Add support for querying the vGPU mode configuration from FSP using
> the PRC (Product Reconfiguration Control) protocol. PRC is an API
> system exposed through FSP's Management Partition that allows querying
> device configuration "knobs" without firmware updates.
>
> Signed-off-by: Zhi Wang <zhiw@xxxxxxxxxx>

Thanks, this is looking really solid now. Just one comment below.

<...>
>  /// Common MCTP and NVDM headers shared by all FSP messages.
>  #[repr(C, packed)]
>  #[derive(Clone, Copy)]
> @@ -84,16 +190,27 @@ fn new(nvdm_type: NvdmType) -> Self {
>      }
>  }
>  
> -/// Complete FSP response structure with MCTP and NVDM headers.
> +/// Common FSP response header with MCTP, NVDM and command response payloads.
>  #[repr(C, packed)]
>  #[derive(Clone, Copy)]
> -struct FspResponse {
> +struct FspResponseHeader {

nit: Can you move the extraction (or rather, the renaming) of
FspResponseHeader into its own patch? We want to stick to the principle
of "one patch does one thing" as much as possible.