Re: [PATCH 2/3] arm64: dts: qcom: lemans-pmics: Add ADC support for PMM8654au

[Konrad Dybcio]

On 6/18/26 12:21 PM, Jishnu Prakash wrote:
> Hi Konrad,
> 
> On 6/15/2026 9:26 PM, Konrad Dybcio wrote:
>> On 4/30/26 10:58 AM, Jishnu Prakash wrote:
>>> From: Ayyagari Ushasreevalli <aushasre@xxxxxxxxxxxxxxxx>
>>>
>>> Add ADC nodes for the four PMM8654au PMICs (pmm8654au_0 through
>>> pmm8654au_3) on the Lemans platform.

[...]

>>> +		pmm8654au_0_adc: adc@8000 {
>>> +			compatible = "qcom,spmi-adc5-gen3";
>>> +			reg = <0x8000>;
>>> +			#address-cells = <1>;
>>> +			#size-cells = <0>;
>>> +			interrupts = <0x0 0x80 0x1 IRQ_TYPE_EDGE_RISING>;
>>> +			#io-channel-cells = <1>;
>>> +
>>> +			channel@3 {
>>> +				reg = <ADC5_GEN3_DIE_TEMP(0)>;
>>> +				label = "pmm8654au_0_die_temp";
>>
>> Are these labels namespaced, i.e. can the label be just "pm8654au_die_temp"
>> or "die_temp"?
> 
> From what I see, there's no functional issue with updating the label to either
> of the names you suggested. We made it this way at first as we thought it would
> be useful to have the exact PMIC instance name in the label of each channel.
> 
> Do you want any changes in the labels? If yes, which convention do you prefer?

I poked around sysfs - let's stick with the existing ones, since
all we get is this label, without a "nice" way to identify which is
which

Konrad