Re: [PATCH 3/7] remoteproc: qcom_q6v5_mss: Use mss as regulator for MSM8953
From: Konrad Dybcio
Date: Tue Jun 30 2026 - 09:16:04 EST
On 6/4/26 2:33 PM, Barnabás Czémán wrote:
>
>
> On 16 April 2026 15:32:25 CEST, Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx> wrote:
>> On 3/27/26 9:11 PM, Barnabás Czémán wrote:
>>> MSM8953 MSS is using mss-supply as regulator what is usually pm8953_s1.
>>>
>>> Signed-off-by: Barnabás Czémán <barnabas.czeman@xxxxxxxxxxxxxx>
>>> ---
>>> drivers/remoteproc/qcom_q6v5_mss.c | 9 ++++++++-
>>> 1 file changed, 8 insertions(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
>>> index 4e9eb5bd11fa..86edd826ede8 100644
>>> --- a/drivers/remoteproc/qcom_q6v5_mss.c
>>> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
>>> @@ -2705,6 +2705,14 @@ static const struct rproc_hexagon_res msm8953_mss = {
>>> },
>>> {}
>>> },
>>> + .active_supply = (struct qcom_mss_reg_res[]) {
>>> + {
>>> + .supply = "mss",
>>> + .uV = 1050000,
>>> + .uA = 100000,
>>
>> I don't know if it's a typo, but msm8953-regulator.dtsi on msm-3.18
>> suggests one more zero
> I do not see any load values there only init-voltage what have six zeros.
Yes, you're right
Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>
Konrad