Re: [PATCH v3 2/4] dt-bindings: media: qcom: Add JPEG encoder binding
From: Bryan O'Donoghue
Date: Tue Jun 30 2026 - 09:25:36 EST
On 29/06/2026 14:38, Vladimir Zapolskiy wrote:
+ interconnects =Since the proper option for describing this hardware is to have it as
+ <&gem_noc MASTER_AMPSS_M0 0 &config_noc SLAVE_CAMERA_CFG 0>,
+ <&mmss_noc MASTER_CAMNOC_HF 0 &mc_virt SLAVE_EBI_CH0 0>,
+ <&mmss_noc MASTER_CAMNOC_SF 0 &mc_virt SLAVE_EBI_CH0 0>,
+ <&mmss_noc MASTER_CAMNOC_ICP 0 &mc_virt SLAVE_EBI_CH0 0>;
+ interconnect-names = "cpu-cfg",
+ "hf-mnoc",
+ "sf-mnoc",
+ "icp-mnoc";
a child device tree node of CAMSS device tree node, which should serve
or be percepted as a bus, it makes no sense to repeat and moreover rename
bus/parent's resources, here is the list:
* "hf_axi", "sf_axi", "core_ahb", "cpas_ahb" and "cnoc_axi" clocks,
* Titan GDSC power domain and all four interconnects.
Only "jpeg" clock and iommus are left specific to the hardware description
of this IP under CAMSS, right? Thus, it should be reflected like this in
the dt description as well, and the complexity of shared resource management
has to be done in the driver, which might be tedious unfortunately, but
certainly doable.
JPEG should be able to vote for its individual NoC / CamNoC dependencies / requirements.
Both GDSCs and interconnects should be described in the sub-node.
There's no functional linkage between CAMSS/IFE and JPEG - they are peers within the CAMSS power-island. Over time we will migrate to individual nodes for IFE CSID and these too will appear inside of the CAMSS "bus" -> JPEG etc should describe their nocs and power-domains individually.
camss@X{
camnoc@{}
csid@{
interconnects = <gem_noc>, <cam_noc>;
};
jpeg@ {
interconnects = <gem_noc>, <cam_noc>;
};
ife@ {
interconnects = <gem_noc>, <cam_noc>;
};
};
That's not where we are but its where we should be going.
---
bod