Re: [PATCH v3 2/8] irqchip/qcom-pdc: Move all statics to struct pdc_desc

From: Thomas Gleixner

Date: Tue Jun 30 2026 - 10:50:26 EST


On Tue, Jun 16 2026 at 14:55, Maulik Shah wrote:
> - for (i = 0; i < pdc_region[n].cnt; i++)
> - __pdc_enable_intr(i + pdc_region[n].pin_base, 0);
> + for (int i = 0; i < pdc->region[n].cnt; i++)
> + pdc->enable_intr(i + pdc->region[n].pin_base, 0);

This needs a guard(raw_spinlock_irqsave)() when invoking
pdc->enable_intr(). The probe function is only invoked
with interrupts disabled during early boot. If it's called later, then
this still works, but lockdep will be rightfully upset.