[PATCH] media: dvb-frontends: a8293: propagate set_voltage errors
From: Nikhil Gurudasani
Date: Tue Jun 30 2026 - 11:04:55 EST
a8293_set_voltage() invokes the slew or non-slew voltage programming
helper but ignores its return value and always reports success.
Propagate the selected helper's status so I2C failures reach the DVB
frontend.
Fixes: e6431a0c0d71 ("media: dvb-frontends: a8293: fix LNB powerup failure in PCTV 461e")
Signed-off-by: Nikhil Gurudasani <nikhilgurudasani314@xxxxxxxxx>
---
drivers/media/dvb-frontends/a8293.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/media/dvb-frontends/a8293.c b/drivers/media/dvb-frontends/a8293.c
index 52e3dc928327..1390068041d2 100644
--- a/drivers/media/dvb-frontends/a8293.c
+++ b/drivers/media/dvb-frontends/a8293.c
@@ -202,12 +202,10 @@ static int a8293_set_voltage(struct dvb_frontend *fe,
/* Use slew version if slew rate is set to a sane value */
if (volt_slew_nanos_per_mv > 0 && volt_slew_nanos_per_mv < 1600)
- a8293_set_voltage_slew(dev, client, fe_sec_voltage,
- volt_slew_nanos_per_mv);
- else
- a8293_set_voltage_noslew(fe, fe_sec_voltage);
+ return a8293_set_voltage_slew(dev, client, fe_sec_voltage,
+ volt_slew_nanos_per_mv);
- return 0;
+ return a8293_set_voltage_noslew(fe, fe_sec_voltage);
}
static int a8293_probe(struct i2c_client *client)
base-commit: dc59e4fea9d83f03bad6bddf3fa2e52491777482
--
2.43.0