Re: [PATCH 6/6] hwmon: (pmbus/max20830): add support for max20830c and max20840c

[Guenter Roeck]

On 6/30/26 01:07, Torreno, Alexis Czezar wrote:
> > >    static const struct of_device_id max20830_of_match[] = {
> > > -	{ .compatible = "adi,max20830" },
> > > +	{ .compatible = "adi,max20830", .data = &max20830_chip },
> > > +	{ .compatible = "adi,max20830c", .data = &max20830c_chip },
> > > +	{ .compatible = "adi,max20840c", .data = &max20840c_chip },
> >
> > "adi,max20830" is a fallback for the other two chips, but that is not how the
> > code is implemented.
>
> I may be inclined to just not use fallback as it seems to be more complicated
> and a bit unnecessary. There's also other devices that may be added on top
> of this so it lessens the complexity. Will edit the bindings regarding this.

You are missing the point. The fallback is perfectly valid. Technically
the driver does not even need to support adi,max20830c and adi,max20840c.
That is only used to validate that the chip is supported. That does not
need a separate devicetree entry.

Guenter