Re: [PATCH 5/6] dt-bindings: hwmon: (pmbus/max20830): add max20830c and max20840c support

From: Guenter Roeck

Date: Tue Jun 30 2026 - 11:10:55 EST


On 6/30/26 01:07, Torreno, Alexis Czezar wrote:


properties:
compatible:
- const: adi,max20830
+ oneOf:
+ - const: adi,max20830
+ - items:
+ - enum:
+ - adi,max20830c
+ - adi,max20840c
+ - const: adi,max20830 # Fallback compatible

Drop the comment, it is obvious. Can this be not a fallback compatible?


After considering the feedback from patch 6/6 regarding this fallback, I think I
would not make this fallback compatible. Will edit out.


The chips are technically identical (register compatible) except for
the device ID string. That can be evaluated in the driver without
requiring a separate compatible entry in the devicetree description.

Guenter