Re: [PATCH 1/6] dt-bindings: hwmon: (pmbus/max20830): add enable-gpios property

[Guenter Roeck]

On 6/30/26 01:07, Torreno, Alexis Czezar wrote:
> > [External]
> >
> > On Tue, Jun 30, 2026 at 10:46:43AM +0800, Alexis Czezar Torreno wrote:
> > > Adding a missing entry for the MAX20830 EN (enable) pin.
> >
> > ... because? Device has it? Was missing?
>
> Yes, device has it and I forgot to include it in the past.

Pretty much every PMBus chip has it. Many non-PMBus hardware
monitoring chips have it. Problem is that there is no practical
use case that I am aware of to connect it to a GPIO pin,
especially for PMBus chips because PMBus (and the chip) has
a command to override it. Connecting the Enable pin to a GPIO
output would mean another extra and unnecessary wire on a board
plus the need for additional software to support - in a more
complex way - what is already supported by the chip itself.

This will even more complicated if anyone ever adds regulator
support to the driver. In order to fully support this, the driver
would have to add support for enabling the chip through the
GPIO pin (or to override it permanently, making it pointless
to have it) even though it is highly unlikely that this code
can ever be tested on real hardware.

That is why I was asking for a use case. "The chip has the
pin" is not a use case.

Thanks,
Guenter