Re: [PATCH 01/12] fs/ceph/super: remove unused field `i_cap_migration_resv`
From: Viacheslav Dubeyko
Date: Tue Jun 30 2026 - 11:51:50 EST
On Fri, 2026-06-12 at 18:51 +0200, Max Kellermann wrote:
> This field was added 17 years ago by commit de57606c23afd ("ceph:
> client types") but it was never used.
>
> This reduces the size of `struct ceph_inode_info` by 8 bytes.
>
> Fixes: de57606c23afd ("ceph: client types")
> Signed-off-by: Max Kellermann <max.kellermann@xxxxxxxxx>
> ---
> fs/ceph/super.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/ceph/super.h b/fs/ceph/super.h
> index afc89ce91804..6aec40955387 100644
> --- a/fs/ceph/super.h
> +++ b/fs/ceph/super.h
> @@ -448,7 +448,6 @@ struct ceph_inode_info {
> wait_queue_head_t i_cap_wq; /* threads waiting on a
> capability */
> unsigned long i_hold_caps_max; /* jiffies */
> struct list_head i_cap_delay_list; /* for delayed cap
> release to mds */
> - struct ceph_cap_reservation i_cap_migration_resv;
> struct list_head i_cap_snaps; /* snapped state pending
> flush to mds */
> struct ceph_snap_context *i_head_snapc; /* set if
> wr_buffer_head > 0 or
> dirty|flushing
> caps */
Removing the dead field makes sense to me.
Reviewed-by: Viacheslav Dubeyko <slava@xxxxxxxxxxx>
Thanks,
Slava.